Archived
Federico Jaramillo Martinez
e77ab98361
A slash command sent as the first (or any idle) message showed the raw command text twice until reload: once from the client's optimistic insert and once from the server's message.append echo, neither of which converges with the agent's canonical expanded message (e.g. a /skill:* block). Make commands obey the same source-of-truth contract as prompts: - client no longer inserts the raw command text optimistically; it shows the existing per-session sending indicator instead - forwarded runtime/skill commands return a bare done result rather than a synthetic "Accepted ..." line - server suppresses the raw message.append echo for command-forwarded prompts (threaded through the compaction queue too) Result: pre-reload state matches reload, with no transient duplicate.
836 lines
36 KiB
TypeScript
836 lines
36 KiB
TypeScript
import { AuthStorage, ModelRegistry } from "@earendil-works/pi-coding-agent";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import type { GlobalSessionEvent, SessionUiEvent } from "../../shared/apiTypes.js";
|
|
import { SessionEventHub } from "../realtime/sessionEventHub.js";
|
|
import { PiSessionService, type PiAgentSession, type PiSessionManager, type PiSessionRuntime, type PiSessionServiceDependencies } from "./piSessionService.js";
|
|
import type { SpawnTargetDecision } from "./spawnTargetResolver.js";
|
|
|
|
class CapturingSessionEventHub extends SessionEventHub {
|
|
readonly sessionEvents: { sessionId: string; event: SessionUiEvent }[] = [];
|
|
readonly globalEvents: GlobalSessionEvent[] = [];
|
|
|
|
override publish(sessionId: string, event: SessionUiEvent): void {
|
|
this.sessionEvents.push({ sessionId, event });
|
|
}
|
|
|
|
override publishGlobal(event: GlobalSessionEvent): void {
|
|
this.globalEvents.push(event);
|
|
}
|
|
}
|
|
|
|
type SessionGateway = NonNullable<PiSessionServiceDependencies["sessionManager"]>;
|
|
type RuntimeCreator = NonNullable<PiSessionServiceDependencies["createAgentRuntime"]>;
|
|
|
|
interface TestSession extends PiAgentSession {
|
|
sessionName: string | undefined;
|
|
model: PiAgentSession["model"];
|
|
isStreaming: boolean;
|
|
isCompacting: boolean;
|
|
isBashRunning: boolean;
|
|
pendingMessageCount: number;
|
|
getSteeringMessages: () => readonly string[];
|
|
getFollowUpMessages: () => readonly string[];
|
|
}
|
|
|
|
function fakeSessionManager(cwd = "/workspace"): PiSessionManager {
|
|
return {
|
|
getCwd: () => cwd,
|
|
getBranch: () => [],
|
|
getLeafId: () => "leaf-1",
|
|
};
|
|
}
|
|
|
|
function sessionRecord(id: string, cwd = "/workspace") {
|
|
return { id, path: `/sessions/${id}.jsonl`, cwd, created: new Date("2026-01-01T00:00:00.000Z"), modified: new Date("2026-01-01T00:01:00.000Z"), messageCount: 0, firstMessage: "", allMessagesText: "" };
|
|
}
|
|
|
|
function sessionRef(id: string, cwd = "/workspace") {
|
|
return { id, cwd };
|
|
}
|
|
|
|
function fakeRuntime(sessionId = "session-1", patch: Partial<TestSession> = {}) {
|
|
const promptCalls: { text: string; options: unknown }[] = [];
|
|
const bindExtensionCalls: unknown[] = [];
|
|
const listeners: ((event: unknown) => void)[] = [];
|
|
const calls = { abort: 0, bindExtensions: bindExtensionCalls, clearQueue: 0, dispose: 0, prompt: promptCalls };
|
|
const session: TestSession = {
|
|
sessionId,
|
|
sessionFile: `/tmp/${sessionId}.jsonl`,
|
|
messages: [],
|
|
sessionName: undefined,
|
|
model: undefined,
|
|
thinkingLevel: "off",
|
|
isStreaming: false,
|
|
isCompacting: false,
|
|
isBashRunning: false,
|
|
pendingMessageCount: 0,
|
|
sessionManager: fakeSessionManager(),
|
|
modelRegistry: ModelRegistry.create(AuthStorage.inMemory()),
|
|
scopedModels: [],
|
|
extensionRunner: { getRegisteredCommands: () => [] },
|
|
promptTemplates: [],
|
|
resourceLoader: { getSkills: () => ({ skills: [] }) },
|
|
subscribe: (listener: (event: unknown) => void) => {
|
|
listeners.push(listener);
|
|
return () => {
|
|
const index = listeners.indexOf(listener);
|
|
if (index !== -1) listeners.splice(index, 1);
|
|
};
|
|
},
|
|
bindExtensions: (bindings: unknown) => {
|
|
calls.bindExtensions.push(bindings);
|
|
return Promise.resolve();
|
|
},
|
|
getSessionStats: () => ({ sessionId, totalMessages: 0, userMessages: 0, assistantMessages: 0, toolCalls: 0, tokens: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 }, cost: 0 }),
|
|
getContextUsage: () => undefined,
|
|
prompt: (text: string, options: unknown) => {
|
|
calls.prompt.push({ text, options });
|
|
return Promise.resolve();
|
|
},
|
|
executeBash: () => Promise.resolve({ output: "", exitCode: 0, cancelled: false, truncated: false }),
|
|
abort: () => {
|
|
calls.abort += 1;
|
|
return Promise.resolve();
|
|
},
|
|
clearQueue: () => {
|
|
calls.clearQueue += 1;
|
|
return { steering: [], followUp: [] };
|
|
},
|
|
getSteeringMessages: () => [],
|
|
getFollowUpMessages: () => [],
|
|
setModel: () => Promise.resolve(),
|
|
cycleModel: () => Promise.resolve(undefined),
|
|
getAvailableThinkingLevels: () => [],
|
|
setThinkingLevel: () => undefined,
|
|
cycleThinkingLevel: () => undefined,
|
|
setSessionName: (name: string) => { session.sessionName = name; },
|
|
compact: () => Promise.resolve({ summary: "", tokensBefore: 0 }),
|
|
getUserMessagesForForking: () => [],
|
|
...patch,
|
|
};
|
|
const runtime: PiSessionRuntime = {
|
|
cwd: session.sessionManager.getCwd(),
|
|
session,
|
|
setRebindSession: () => undefined,
|
|
fork: () => Promise.resolve({ cancelled: false }),
|
|
dispose: () => {
|
|
calls.dispose += 1;
|
|
return Promise.resolve();
|
|
},
|
|
};
|
|
return { runtime, session, calls, emit: (event: unknown) => { for (const listener of [...listeners]) listener(event); } };
|
|
}
|
|
|
|
function runtimeCreator(runtime: PiSessionRuntime): RuntimeCreator {
|
|
return async () => {
|
|
await Promise.resolve();
|
|
return runtime;
|
|
};
|
|
}
|
|
|
|
function sessionGateway(records: ReturnType<typeof sessionRecord>[]): SessionGateway {
|
|
return {
|
|
create: () => fakeSessionManager(),
|
|
list: () => Promise.resolve(records),
|
|
open: () => fakeSessionManager(),
|
|
};
|
|
}
|
|
|
|
describe("PiSessionService", () => {
|
|
it("starts sessions through an injected runtime creator", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime();
|
|
let createCalls = 0;
|
|
const createAgentRuntime: RuntimeCreator = async () => {
|
|
createCalls += 1;
|
|
await Promise.resolve();
|
|
return fake.runtime;
|
|
};
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime,
|
|
sessionManager: sessionGateway([]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
const session = await service.start("/workspace");
|
|
|
|
expect(createCalls).toBe(1);
|
|
expect(fake.calls.bindExtensions).toHaveLength(1);
|
|
expect(session).toMatchObject({ id: "session-1", cwd: "/workspace", messageCount: 0 });
|
|
expect(service.activeCount()).toBe(1);
|
|
expect(hub.globalEvents.some((event) => event.type === "status.update" && event.status.sessionId === "session-1")).toBe(true);
|
|
expect(hub.globalEvents.some((event) => event.type === "session.created" && event.session.id === "session-1" && event.session.cwd === "/workspace")).toBe(true);
|
|
|
|
await service.dispose();
|
|
expect(fake.calls.abort).toBe(1);
|
|
expect(fake.calls.dispose).toBe(1);
|
|
});
|
|
|
|
it("opens legacy id-only lookups from the default session store gateway", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime("legacy-session");
|
|
const open = vi.fn(() => fakeSessionManager());
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: {
|
|
create: () => fakeSessionManager(),
|
|
list: () => Promise.resolve([]),
|
|
listAll: () => Promise.resolve([sessionRecord("legacy-session")]),
|
|
open,
|
|
},
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.status("legacy")).resolves.toMatchObject({ sessionId: "legacy-session" });
|
|
expect(open).toHaveBeenCalledWith("/sessions/legacy-session.jsonl");
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("binds extensions again when the SDK runtime replaces the active session", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime("session-1");
|
|
const replacement = fakeRuntime("session-2");
|
|
let rebindSession: ((session: PiAgentSession) => Promise<void>) | undefined;
|
|
fake.runtime.setRebindSession = (callback) => { rebindSession = callback; };
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.start("/workspace");
|
|
Object.defineProperty(fake.runtime, "session", { configurable: true, value: replacement.session });
|
|
await rebindSession?.(replacement.session);
|
|
|
|
expect(fake.calls.bindExtensions).toHaveLength(1);
|
|
expect(replacement.calls.bindExtensions).toHaveLength(1);
|
|
expect(service.activeCount()).toBe(1);
|
|
expect(await service.status("session-2")).toMatchObject({ sessionId: "session-2" });
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("publishes extension errors reported while binding session extensions", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime("extension-session", {
|
|
bindExtensions: (bindings) => {
|
|
bindings.onError?.({ extensionPath: "pi-mcp-adapter", event: "session_start", error: "MCP failed" });
|
|
return Promise.resolve();
|
|
},
|
|
});
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.start("/workspace");
|
|
|
|
expect(hub.sessionEvents).toContainEqual({
|
|
sessionId: "extension-session",
|
|
event: { type: "session.error", message: "pi-mcp-adapter: MCP failed" },
|
|
});
|
|
const extensionErrorActivity = hub.globalEvents.find((event) => event.type === "activity.update" && event.activity.sessionId === "extension-session");
|
|
expect(extensionErrorActivity).toMatchObject({
|
|
type: "activity.update",
|
|
activity: { sessionId: "extension-session", phase: "error", label: "extension error", detail: "pi-mcp-adapter: MCP failed" },
|
|
});
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("clears stale active activity once a previously active session becomes idle", async () => {
|
|
vi.useFakeTimers();
|
|
let service: PiSessionService | undefined;
|
|
try {
|
|
const hub = new CapturingSessionEventHub();
|
|
let listener: ((event: unknown) => void) | undefined;
|
|
const fake = fakeRuntime("idle-session", {
|
|
isStreaming: true,
|
|
subscribe: (next) => {
|
|
listener = next;
|
|
return () => undefined;
|
|
},
|
|
});
|
|
service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("idle-session")]),
|
|
heartbeatIntervalMs: 1_000,
|
|
});
|
|
|
|
await service.status(sessionRef("idle-session"));
|
|
hub.globalEvents.length = 0;
|
|
listener?.({ type: "agent_start" });
|
|
|
|
const activityPhases = () => hub.globalEvents
|
|
.filter((event) => event.type === "activity.update")
|
|
.map((event) => event.activity.phase);
|
|
expect(activityPhases()).toEqual(["active"]);
|
|
|
|
fake.session.isStreaming = false;
|
|
await vi.advanceTimersByTimeAsync(1_000);
|
|
await vi.advanceTimersByTimeAsync(1_000);
|
|
|
|
expect(activityPhases()).toEqual(["active", "idle"]);
|
|
} finally {
|
|
await service?.dispose();
|
|
vi.useRealTimers();
|
|
}
|
|
});
|
|
|
|
it("publishes idle activity for SDK completion events", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
let listener: ((event: unknown) => void) | undefined;
|
|
const fake = fakeRuntime("completion-session", {
|
|
subscribe: (next) => {
|
|
listener = next;
|
|
return () => undefined;
|
|
},
|
|
});
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("completion-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.status(sessionRef("completion-session"));
|
|
hub.globalEvents.length = 0;
|
|
listener?.({ type: "tool_execution_end", toolName: "read", isError: false });
|
|
|
|
expect(hub.globalEvents.filter((event) => event.type === "activity.update")).toMatchObject([
|
|
{ activity: { sessionId: "completion-session", phase: "idle", label: "tool complete", detail: "read" } },
|
|
]);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("uses injected archive and session-manager gateways for listing", async () => {
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
archiveStore: {
|
|
list: () => Promise.resolve([{ sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-01T00:00:00.000Z" }]),
|
|
get: () => Promise.resolve(undefined),
|
|
archive: () => Promise.resolve({ sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-01T00:00:00.000Z" }),
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(false),
|
|
},
|
|
sessionManager: {
|
|
create: () => fakeSessionManager(),
|
|
list: () => Promise.resolve([
|
|
{ ...sessionRecord("active"), messageCount: 1, firstMessage: "hello", allMessagesText: "hello" },
|
|
{ ...sessionRecord("archived"), messageCount: 2, firstMessage: "bye", allMessagesText: "bye" },
|
|
]),
|
|
open: () => fakeSessionManager(),
|
|
},
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
const sessions = await service.list("/workspace");
|
|
expect(sessions).toHaveLength(2);
|
|
expect(sessions[0]).toMatchObject({ id: "active" });
|
|
expect(sessions[0]?.archived).toBeUndefined();
|
|
expect(sessions[1]).toMatchObject({ id: "archived", archived: true, archivedAt: "2026-01-01T00:00:00.000Z" });
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("lists archived records that have been moved out of the active session directory", async () => {
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
archiveStore: {
|
|
list: () => Promise.resolve([{ sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z", originalPath: "/sessions/archived.jsonl", archivePath: "/archive/archived.jsonl", created: "2026-01-01T00:00:00.000Z", modified: "2026-01-01T00:01:00.000Z", messageCount: 2, firstMessage: "bye" }]),
|
|
get: () => Promise.resolve(undefined),
|
|
archive: () => { throw new Error("archive should not be called for moved records"); },
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(false),
|
|
},
|
|
sessionManager: {
|
|
create: () => fakeSessionManager(),
|
|
list: () => Promise.resolve([{ ...sessionRecord("active"), messageCount: 1, firstMessage: "hello", allMessagesText: "hello" }]),
|
|
open: () => fakeSessionManager(),
|
|
},
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
const sessions = await service.list("/workspace");
|
|
|
|
expect(sessions).toHaveLength(2);
|
|
expect(sessions[0]).toMatchObject({ id: "active" });
|
|
expect(sessions[0]?.archived).toBeUndefined();
|
|
expect(sessions[1]).toMatchObject({ id: "archived", path: "/sessions/archived.jsonl", archived: true, archivedAt: "2026-01-02T00:00:00.000Z" });
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("archives a session subtree within the root workspace", async () => {
|
|
const archivedInputs: string[] = [];
|
|
const root = sessionRecord("root");
|
|
const directChild = { ...sessionRecord("direct-child"), path: "/sessions/direct-child.jsonl", parentSessionPath: root.path };
|
|
const archivedChild = { ...sessionRecord("archived-child"), path: "/sessions/archived-child.jsonl", parentSessionPath: root.path };
|
|
const grandchild = { ...sessionRecord("grandchild"), path: "/sessions/grandchild.jsonl", parentSessionPath: archivedChild.path };
|
|
const otherWorkspaceChild = { ...sessionRecord("other-child", "/other"), path: "/sessions/other-child.jsonl", parentSessionPath: root.path };
|
|
const fake = fakeRuntime("root", { sessionFile: root.path });
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
archiveStore: {
|
|
list: () => Promise.resolve([{ sessionId: "archived-child", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z", originalPath: archivedChild.path, archivePath: "/archive/archived-child.jsonl", created: "2026-01-01T00:00:00.000Z", modified: "2026-01-01T00:01:00.000Z", messageCount: 1, firstMessage: "archived", parentSessionPath: root.path }]),
|
|
get: () => Promise.resolve(undefined),
|
|
archive: (input) => {
|
|
archivedInputs.push(input.sessionId);
|
|
return Promise.resolve({ sessionId: input.sessionId, cwd: input.cwd, archivedAt: "2026-01-03T00:00:00.000Z" });
|
|
},
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(false),
|
|
},
|
|
sessionManager: {
|
|
create: () => fakeSessionManager(),
|
|
list: (cwd) => Promise.resolve(cwd === "/workspace" ? [root, directChild, archivedChild, grandchild] : [otherWorkspaceChild]),
|
|
open: () => fakeSessionManager(),
|
|
},
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.archiveTree(sessionRef("root"))).resolves.toEqual({
|
|
archived: true,
|
|
sessionIds: ["root", "direct-child", "grandchild"],
|
|
archivedCount: 3,
|
|
skippedAlreadyArchivedCount: 1,
|
|
});
|
|
expect(archivedInputs).toEqual(["root", "direct-child", "grandchild"]);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("permanently deletes archived sessions through the archive store", async () => {
|
|
const deletedSessionIds: string[] = [];
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
archiveStore: {
|
|
list: () => Promise.resolve([]),
|
|
get: (sessionId) => Promise.resolve(sessionId === "archived" || "archived".startsWith(sessionId)
|
|
? { sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z", archivePath: "/archive/archived.jsonl" }
|
|
: undefined),
|
|
archive: () => { throw new Error("archive should not be called for records that already have archive files"); },
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(false),
|
|
deleteArchived: (sessionId) => {
|
|
deletedSessionIds.push(sessionId);
|
|
return Promise.resolve();
|
|
},
|
|
},
|
|
sessionManager: sessionGateway([sessionRecord("active")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.deleteArchived("arch")).resolves.toBeUndefined();
|
|
await expect(service.deleteArchived("active")).rejects.toThrow("Archived session not found");
|
|
|
|
expect(deletedSessionIds).toEqual(["archived"]);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("reloads a session by closing the active runtime and re-opening it from disk", async () => {
|
|
const first = fakeRuntime("reload-session");
|
|
const second = fakeRuntime("reload-session");
|
|
const runtimes = [first.runtime, second.runtime];
|
|
let createCalls = 0;
|
|
const createAgentRuntime: RuntimeCreator = async () => {
|
|
await Promise.resolve();
|
|
const runtime = runtimes[createCalls];
|
|
createCalls += 1;
|
|
if (runtime === undefined) throw new Error("unexpected runtime creation");
|
|
return runtime;
|
|
};
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime,
|
|
sessionManager: sessionGateway([sessionRecord("reload-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
// Open once so there is an active runtime to reload.
|
|
await service.status(sessionRef("reload-session"));
|
|
expect(createCalls).toBe(1);
|
|
|
|
await expect(service.reload(sessionRef("reload-session"))).resolves.toBeUndefined();
|
|
|
|
// The original runtime was torn down and a fresh one opened from disk.
|
|
expect(first.calls.abort).toBe(1);
|
|
expect(first.calls.dispose).toBe(1);
|
|
expect(createCalls).toBe(2);
|
|
expect(service.activeCount()).toBe(1);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("refuses to reload a session that has active work in progress", async () => {
|
|
const fake = fakeRuntime("busy-session", { isStreaming: true });
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("busy-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.reload(sessionRef("busy-session"))).rejects.toThrow("Stop current session activity before reloading");
|
|
expect(fake.calls.abort).toBe(0);
|
|
expect(fake.calls.dispose).toBe(0);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("refuses to reload an archived session", async () => {
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
archiveStore: {
|
|
list: () => Promise.resolve([]),
|
|
get: (sessionId) => Promise.resolve(sessionId === "archived" || "archived".startsWith(sessionId)
|
|
? { sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z", archivePath: "/archive/archived.jsonl" }
|
|
: undefined),
|
|
archive: () => Promise.resolve({ sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z" }),
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(true),
|
|
},
|
|
sessionManager: sessionGateway([]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.reload(sessionRef("archived"))).rejects.toThrow("Archived sessions are read-only");
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("reconciles workspace activity when listing only archived sessions", async () => {
|
|
const reconciliations: { cwd: string; sessionIds: string[] }[] = [];
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
archiveStore: {
|
|
list: () => Promise.resolve([{ sessionId: "archived", cwd: "/workspace", archivedAt: "2026-01-02T00:00:00.000Z", originalPath: "/sessions/archived.jsonl", archivePath: "/archive/archived.jsonl", created: "2026-01-01T00:00:00.000Z", modified: "2026-01-01T00:01:00.000Z", messageCount: 2, firstMessage: "bye" }]),
|
|
get: () => Promise.resolve(undefined),
|
|
archive: () => { throw new Error("archive should not be called for moved records"); },
|
|
restore: () => Promise.resolve(),
|
|
isArchived: () => Promise.resolve(false),
|
|
},
|
|
sessionManager: {
|
|
create: () => fakeSessionManager(),
|
|
list: () => Promise.resolve([]),
|
|
open: () => fakeSessionManager(),
|
|
},
|
|
workspaceActivity: {
|
|
applySessionStatus: () => undefined,
|
|
applySessionActivity: () => undefined,
|
|
removeSession: () => undefined,
|
|
reconcileSessionActivity: (cwd, sessionIds) => { reconciliations.push({ cwd, sessionIds: [...sessionIds] }); },
|
|
},
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
const sessions = await service.list("/workspace");
|
|
|
|
expect(sessions).toHaveLength(1);
|
|
expect(sessions[0]).toMatchObject({ id: "archived", archived: true });
|
|
expect(reconciliations).toEqual([{ cwd: "/workspace", sessionIds: [] }]);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("sends prompts to an injected runtime without touching the SDK runtime", async () => {
|
|
const fake = fakeRuntime("prompt-session");
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("prompt-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("prompt-session"), "Build the thing");
|
|
|
|
expect(fake.calls.prompt).toEqual([{ text: "Build the thing", options: undefined }]);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("echoes the user message for direct prompts but not command-forwarded ones", async () => {
|
|
const fake = fakeRuntime("echo-session", {
|
|
resourceLoader: { getSkills: () => ({ skills: [{ name: "skill-creator" }] }) },
|
|
});
|
|
const hub = new CapturingSessionEventHub();
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("echo-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("echo-session"), "Build the thing");
|
|
expect(hub.sessionEvents.filter(({ event }) => event.type === "message.append")).toHaveLength(1);
|
|
|
|
// The client optimistically renders command-forwarded prompts (e.g. /skill:*),
|
|
// so the server must not publish a second copy via message.append.
|
|
await service.runCommand(sessionRef("echo-session"), "/skill:skill-creator");
|
|
expect(hub.sessionEvents.filter(({ event }) => event.type === "message.append")).toHaveLength(1);
|
|
expect(fake.calls.prompt).toEqual([
|
|
{ text: "Build the thing", options: undefined },
|
|
{ text: "/skill:skill-creator", options: undefined },
|
|
]);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("rejects malformed prompt text before opening the runtime", async () => {
|
|
const fake = fakeRuntime("prompt-session");
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("prompt-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.prompt("prompt-session", undefined)).rejects.toThrow("Prompt text is required");
|
|
|
|
expect(fake.calls.prompt).toEqual([]);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("includes queued message details in session status", async () => {
|
|
const fake = fakeRuntime("status-session", {
|
|
messages: [{ role: "user", content: "hello" }, { role: "assistant", content: "hi" }],
|
|
pendingMessageCount: 2,
|
|
getSteeringMessages: () => ["adjust this turn"],
|
|
getFollowUpMessages: () => ["then do this"],
|
|
});
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("status-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.status(sessionRef("status-session"))).resolves.toMatchObject({
|
|
pendingMessageCount: 2,
|
|
queuedMessages: [{ kind: "steer", text: "adjust this turn" }, { kind: "followUp", text: "then do this" }],
|
|
messageCount: 2,
|
|
});
|
|
await service.dispose();
|
|
});
|
|
|
|
it("does not enqueue duplicate queued message text", async () => {
|
|
const fake = fakeRuntime("dedupe-session", {
|
|
isStreaming: true,
|
|
pendingMessageCount: 1,
|
|
getFollowUpMessages: () => ["already queued"],
|
|
});
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("dedupe-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("dedupe-session"), "already queued", "followUp");
|
|
|
|
expect(fake.calls.prompt).toEqual([]);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("does not append queued prompts to the transcript before delivery", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime("queued-session", { isStreaming: true });
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("queued-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("queued-session"), "Wait for the current turn", "followUp");
|
|
|
|
expect(fake.calls.prompt).toEqual([{ text: "Wait for the current turn", options: { streamingBehavior: "followUp" } }]);
|
|
expect(hub.sessionEvents.some(({ event }) => event.type === "message.append")).toBe(false);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("holds prompts sent during compaction until compaction finishes", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const fake = fakeRuntime("compacting-session", { isCompacting: true });
|
|
let resolveFirstPrompt: (() => void) | undefined;
|
|
fake.session.prompt = (text: string, options?: { streamingBehavior?: "steer" | "followUp" }) => {
|
|
fake.calls.prompt.push({ text, options });
|
|
if (options === undefined) {
|
|
fake.session.isStreaming = true;
|
|
return new Promise<void>((resolve) => { resolveFirstPrompt = resolve; });
|
|
}
|
|
return Promise.resolve();
|
|
};
|
|
const service = new PiSessionService(hub, {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("compacting-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("compacting-session"), "Start task 1", "followUp");
|
|
await service.prompt(sessionRef("compacting-session"), "Then task 2", "followUp");
|
|
|
|
expect(fake.calls.prompt).toEqual([]);
|
|
expect(hub.sessionEvents.some(({ event }) => event.type === "message.append")).toBe(false);
|
|
await expect(service.status(sessionRef("compacting-session"))).resolves.toMatchObject({
|
|
pendingMessageCount: 2,
|
|
queuedMessages: [{ kind: "followUp", text: "Start task 1" }, { kind: "followUp", text: "Then task 2" }],
|
|
});
|
|
|
|
fake.session.isCompacting = false;
|
|
fake.emit({ type: "compaction_end" });
|
|
await new Promise((resolve) => setTimeout(resolve, 5));
|
|
|
|
expect(fake.calls.prompt).toEqual([{ text: "Start task 1", options: undefined }]);
|
|
expect(hub.sessionEvents.some(({ event }) => event.type === "message.append" && JSON.stringify(event.message).includes("Start task 1"))).toBe(true);
|
|
await expect(service.status(sessionRef("compacting-session"))).resolves.toMatchObject({
|
|
pendingMessageCount: 1,
|
|
queuedMessages: [{ kind: "followUp", text: "Then task 2" }],
|
|
});
|
|
|
|
fake.emit({ type: "agent_start" });
|
|
await new Promise((resolve) => setTimeout(resolve, 5));
|
|
|
|
expect(fake.calls.prompt).toEqual([
|
|
{ text: "Start task 1", options: undefined },
|
|
{ text: "Then task 2", options: { streamingBehavior: "followUp" } },
|
|
]);
|
|
await expect(service.status(sessionRef("compacting-session"))).resolves.toMatchObject({
|
|
pendingMessageCount: 0,
|
|
queuedMessages: [],
|
|
});
|
|
resolveFirstPrompt?.();
|
|
await service.dispose();
|
|
});
|
|
|
|
it("clears queued messages when aborting active work", async () => {
|
|
const fake = fakeRuntime("abort-session");
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("abort-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.status(sessionRef("abort-session"));
|
|
await service.abort(sessionRef("abort-session"));
|
|
|
|
expect(fake.calls.clearQueue).toBe(1);
|
|
expect(fake.calls.abort).toBe(1);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("clears prompts queued during compaction when aborting active work", async () => {
|
|
const fake = fakeRuntime("abort-compaction-session", { isCompacting: true });
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("abort-compaction-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.prompt(sessionRef("abort-compaction-session"), "Do not deliver after abort", "followUp");
|
|
await expect(service.status(sessionRef("abort-compaction-session"))).resolves.toMatchObject({ pendingMessageCount: 1 });
|
|
await service.abort(sessionRef("abort-compaction-session"));
|
|
|
|
expect(fake.calls.clearQueue).toBe(1);
|
|
expect(fake.calls.prompt).toEqual([]);
|
|
await expect(service.status(sessionRef("abort-compaction-session"))).resolves.toMatchObject({ pendingMessageCount: 0, queuedMessages: [] });
|
|
await service.dispose();
|
|
});
|
|
|
|
it("refreshes auth state and dedupes warnings when logout removes the current model's credentials", async () => {
|
|
const hub = new CapturingSessionEventHub();
|
|
const authStorage = AuthStorage.inMemory({ anthropic: { type: "api_key", key: "sk-test" } });
|
|
const modelRegistry = ModelRegistry.inMemory(authStorage);
|
|
const model = modelRegistry.find("anthropic", "claude-3-5-sonnet-20241022");
|
|
if (model === undefined) throw new Error("Expected Anthropic model fixture");
|
|
const fake = fakeRuntime("auth-session", { model, modelRegistry });
|
|
|
|
const service = new PiSessionService(hub, {
|
|
modelRegistry,
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("auth-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.status(sessionRef("auth-session"));
|
|
hub.sessionEvents.length = 0;
|
|
hub.globalEvents.length = 0;
|
|
|
|
authStorage.logout("anthropic");
|
|
service.applyAuthChange({ removedProviderId: "anthropic" });
|
|
service.applyAuthChange({ removedProviderId: "anthropic" });
|
|
|
|
const warningCount = () => hub.sessionEvents.filter(({ event }) => event.type === "command.output" && event.level === "error" && event.message.includes("anthropic/claude-3-5-sonnet-20241022")).length;
|
|
expect(warningCount()).toBe(1);
|
|
expect(hub.globalEvents.some((event) => event.type === "status.update" && event.status.sessionId === "auth-session")).toBe(true);
|
|
|
|
authStorage.set("anthropic", { type: "api_key", key: "sk-new" });
|
|
service.applyAuthChange();
|
|
authStorage.logout("anthropic");
|
|
service.applyAuthChange({ removedProviderId: "anthropic" });
|
|
expect(warningCount()).toBe(2);
|
|
|
|
await service.dispose();
|
|
});
|
|
|
|
it("clears queued messages when stopping a session runtime", async () => {
|
|
const fake = fakeRuntime("stop-session");
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([sessionRecord("stop-session")]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await service.status(sessionRef("stop-session"));
|
|
service.stop(sessionRef("stop-session"));
|
|
|
|
expect(fake.calls.clearQueue).toBe(1);
|
|
await service.dispose();
|
|
});
|
|
|
|
describe("spawnSession", () => {
|
|
function spawnService(decision: SpawnTargetDecision) {
|
|
const fake = fakeRuntime("spawned-1", { sessionFile: "/tmp/spawned-1.jsonl" });
|
|
const log: { details: Record<string, unknown>; message: string }[] = [];
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([]),
|
|
spawnTargets: { resolveSpawnTarget: () => Promise.resolve(decision) },
|
|
logger: { info: (details, message) => { log.push({ details, message }); } },
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
return { fake, service, log };
|
|
}
|
|
|
|
it("starts a session at the resolved target, delivers the prompt, and logs the spawn", async () => {
|
|
const { fake, service, log } = spawnService({ allowed: true, cwd: "/workspace-feature" });
|
|
|
|
const result = await service.spawnSession({ spawningCwd: "/workspace", prompt: "continue the plan", cwd: "/workspace-feature" });
|
|
|
|
expect(result).toEqual({ sessionId: "spawned-1", cwd: "/workspace-feature" });
|
|
expect(fake.calls.prompt).toEqual([{ text: "continue the plan", options: undefined }]);
|
|
expect(log).toEqual([{ details: { spawningCwd: "/workspace", sessionId: "spawned-1", cwd: "/workspace-feature", promptLength: 17 }, message: "spawn_session started a new session" }]);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("rejects an out-of-project target without starting a session", async () => {
|
|
const { fake, service } = spawnService({ allowed: false, reason: "out-of-project", allowedCwds: ["/workspace"] });
|
|
|
|
await expect(service.spawnSession({ spawningCwd: "/workspace", prompt: "go", cwd: "/elsewhere" }))
|
|
.rejects.toThrow("cwd must be a workspace of this project. Allowed: /workspace");
|
|
expect(fake.calls.prompt).toEqual([]);
|
|
expect(service.activeCount()).toBe(0);
|
|
await service.dispose();
|
|
});
|
|
|
|
it("rejects when the spawning session is not in a registered project", async () => {
|
|
const { service } = spawnService({ allowed: false, reason: "not-registered" });
|
|
|
|
await expect(service.spawnSession({ spawningCwd: "/workspace", prompt: "go", cwd: undefined }))
|
|
.rejects.toThrow("Spawning session is not in a registered project");
|
|
await service.dispose();
|
|
});
|
|
|
|
it("is disabled when no spawn target resolver is configured", async () => {
|
|
const fake = fakeRuntime("spawned-x");
|
|
const service = new PiSessionService(new CapturingSessionEventHub(), {
|
|
createAgentRuntime: runtimeCreator(fake.runtime),
|
|
sessionManager: sessionGateway([]),
|
|
heartbeatIntervalMs: 60_000,
|
|
});
|
|
|
|
await expect(service.spawnSession({ spawningCwd: "/workspace", prompt: "go", cwd: undefined }))
|
|
.rejects.toThrow("Spawning sessions is disabled");
|
|
await service.dispose();
|
|
});
|
|
});
|
|
});
|