Archived
Split subsession inspection into two tools: check_subsession gives a quick glance (status + latest assistant output), while read_subsession reads through a child's transcript with role/content filters, full-content substring search (including tool-call args), optional per-value maxChars truncation that flags clipped parts, includeToolArgs, and pagination. Filtering and search run on full untruncated content; truncation is an explicit, caller-owned final projection (no default) so a narrow read never silently hides a match. Empty page-windows are distinguished from zero-match results.
150 lines
7.8 KiB
TypeScript
150 lines
7.8 KiB
TypeScript
import type { ImageContent, TextContent } from "@earendil-works/pi-ai";
|
|
import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { createSubsessionToolDefinitions, type SubsessionToolDeps } from "./spawnSubsessionTool.js";
|
|
|
|
function ctxFor(sessionId: string, sessionFile: string | undefined): ExtensionContext {
|
|
const sessionManager = { getSessionId: () => sessionId, getSessionFile: () => sessionFile };
|
|
// The subsession tools only read sessionManager.getSessionId/getSessionFile.
|
|
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- test stub with the minimal surface the tools use.
|
|
return { sessionManager } as unknown as ExtensionContext;
|
|
}
|
|
|
|
function tools(deps: Partial<SubsessionToolDeps>) {
|
|
const full: SubsessionToolDeps = {
|
|
spawn: deps.spawn ?? vi.fn(() => Promise.resolve({ sessionId: "x", cwd: "/repos/a" })),
|
|
list: deps.list ?? vi.fn(() => Promise.resolve([])),
|
|
check: deps.check ?? vi.fn(() => Promise.resolve({ sessionId: "x", cwd: "/repos/a", status: "idle" as const, finalText: "", messageCount: 0 })),
|
|
read: deps.read ?? vi.fn(() => Promise.resolve({ sessionId: "x", cwd: "/repos/a", status: "idle" as const, entries: [], total: 0, matched: 0, start: 0, hasMore: false })),
|
|
};
|
|
const definitions = createSubsessionToolDefinitions("/repos/a", full);
|
|
const find = (name: string) => {
|
|
const tool = definitions.find((definition) => definition.name === name);
|
|
if (tool === undefined) throw new Error(`missing tool ${name}`);
|
|
return tool;
|
|
};
|
|
return { spawn: find("spawn_subsession"), list: find("list_subsessions"), check: find("check_subsession"), read: find("read_subsession") };
|
|
}
|
|
|
|
function firstText(content: readonly (TextContent | ImageContent)[]): string {
|
|
const first = content[0];
|
|
return first?.type === "text" ? first.text : "";
|
|
}
|
|
|
|
describe("createSubsessionToolDefinitions", () => {
|
|
it("spawn_subsession forwards parent identity and params from the live context", async () => {
|
|
const spawn = vi.fn(() => Promise.resolve({ sessionId: "child-1", cwd: "/repos/a-feature" }));
|
|
const { spawn: spawnTool } = tools({ spawn });
|
|
|
|
const result = await spawnTool.execute("call-1", { prompt: "do it", cwd: "/repos/a-feature" }, undefined, undefined, ctxFor("parent-1", "/sessions/parent-1.jsonl"));
|
|
|
|
expect(spawn).toHaveBeenCalledWith({
|
|
spawningCwd: "/repos/a",
|
|
parentSessionId: "parent-1",
|
|
parentSessionFile: "/sessions/parent-1.jsonl",
|
|
prompt: "do it",
|
|
cwd: "/repos/a-feature",
|
|
});
|
|
expect(result.details).toEqual({ sessionId: "child-1", cwd: "/repos/a-feature" });
|
|
expect(firstText(result.content)).toContain("Started subsession child-1");
|
|
});
|
|
|
|
it("list_subsessions reports the caller's subsessions and their status", async () => {
|
|
const list = vi.fn(() => Promise.resolve([
|
|
{ sessionId: "child-1", cwd: "/repos/a", status: "working" as const },
|
|
{ sessionId: "child-2", cwd: "/repos/a", status: "idle" as const },
|
|
]));
|
|
const { list: listTool } = tools({ list });
|
|
|
|
const result = await listTool.execute("call-2", {}, undefined, undefined, ctxFor("parent-1", undefined));
|
|
|
|
expect(list).toHaveBeenCalledWith("parent-1");
|
|
expect(result.details).toEqual({ subsessions: [
|
|
{ sessionId: "child-1", cwd: "/repos/a", status: "working" },
|
|
{ sessionId: "child-2", cwd: "/repos/a", status: "idle" },
|
|
] });
|
|
expect(firstText(result.content)).toContain("child-1 [working]");
|
|
});
|
|
|
|
it("list_subsessions reports an empty state", async () => {
|
|
const { list: listTool } = tools({ list: vi.fn(() => Promise.resolve([])) });
|
|
const result = await listTool.execute("call-3", {}, undefined, undefined, ctxFor("parent-1", undefined));
|
|
expect(result.content[0]).toMatchObject({ type: "text", text: "You have not spawned any subsessions." });
|
|
});
|
|
|
|
it("check_subsession scopes by parent and returns the final result", async () => {
|
|
const check = vi.fn(() => Promise.resolve({ sessionId: "child-1", cwd: "/repos/a", status: "idle" as const, finalText: "all done", messageCount: 4 }));
|
|
const { check: checkTool } = tools({ check });
|
|
|
|
const result = await checkTool.execute("call-4", { sessionId: "child-1" }, undefined, undefined, ctxFor("parent-1", undefined));
|
|
|
|
expect(check).toHaveBeenCalledWith("parent-1", "child-1");
|
|
expect(result.details).toMatchObject({ sessionId: "child-1", status: "idle", finalText: "all done" });
|
|
expect(firstText(result.content)).toContain("all done");
|
|
});
|
|
|
|
it("check_subsession propagates scope errors so the agent loop reports them", async () => {
|
|
const check = vi.fn(() => Promise.reject(new Error("Session child-9 is not one of your subsessions")));
|
|
const { check: checkTool } = tools({ check });
|
|
|
|
await expect(checkTool.execute("call-5", { sessionId: "child-9" }, undefined, undefined, ctxFor("parent-1", undefined)))
|
|
.rejects.toThrow("not one of your subsessions");
|
|
});
|
|
|
|
it("read_subsession forwards filter params and renders the transcript", async () => {
|
|
const read = vi.fn(() => Promise.resolve({
|
|
sessionId: "child-1", cwd: "/repos/a", status: "idle" as const,
|
|
entries: [{ index: 2, role: "assistant" as const, parts: [{ kind: "text" as const, text: "the answer" }] }],
|
|
total: 5, matched: 1, start: 2, hasMore: false,
|
|
}));
|
|
const { read: readTool } = tools({ read });
|
|
|
|
const result = await readTool.execute("call-6", { sessionId: "child-1", roles: ["assistant"], maxChars: 200 }, undefined, undefined, ctxFor("parent-1", undefined));
|
|
|
|
expect(read).toHaveBeenCalledWith("parent-1", "child-1", { roles: ["assistant"], maxChars: 200 });
|
|
expect(result.details).toMatchObject({ sessionId: "child-1", matched: 1 });
|
|
expect(firstText(result.content)).toContain("the answer");
|
|
});
|
|
|
|
it("read_subsession renders raw tool-call args and the truncation marker in the model-facing text", async () => {
|
|
const read = vi.fn(() => Promise.resolve({
|
|
sessionId: "child-1", cwd: "/repos/a", status: "idle" as const,
|
|
entries: [{
|
|
index: 1, role: "assistant" as const, parts: [
|
|
{ kind: "tool_call" as const, toolName: "bash", summary: "ls", args: { command: "ls -la" } },
|
|
{ kind: "text" as const, text: "clipped", truncated: { shown: 7, full: 50 } },
|
|
],
|
|
}],
|
|
total: 3, matched: 1, start: 1, hasMore: false,
|
|
}));
|
|
const { read: readTool } = tools({ read });
|
|
|
|
const result = await readTool.execute("call-7", { sessionId: "child-1", includeToolArgs: true }, undefined, undefined, ctxFor("parent-1", undefined));
|
|
const text = firstText(result.content);
|
|
expect(text).toContain("command"); // raw args surfaced in text, not only details
|
|
expect(text).toContain("ls -la");
|
|
expect(text).toContain("[+43 chars truncated"); // 50 - 7
|
|
});
|
|
|
|
it("read_subsession distinguishes an empty page-window from a zero-match result", async () => {
|
|
const read = vi.fn(() => Promise.resolve({
|
|
sessionId: "child-1", cwd: "/repos/a", status: "idle" as const,
|
|
entries: [], total: 5, matched: 4, start: 0, hasMore: false,
|
|
}));
|
|
const { read: readTool } = tools({ read });
|
|
|
|
const result = await readTool.execute("call-8", { sessionId: "child-1", before: 0 }, undefined, undefined, ctxFor("parent-1", undefined));
|
|
const text = firstText(result.content);
|
|
expect(text).toContain("4 matched"); // not "nothing matched"
|
|
expect(text).not.toContain("nothing matched");
|
|
});
|
|
|
|
it("read_subsession propagates scope errors so the agent loop reports them", async () => {
|
|
const read = vi.fn(() => Promise.reject(new Error("Session child-9 is not one of your subsessions")));
|
|
const { read: readTool } = tools({ read });
|
|
|
|
await expect(readTool.execute("call-9", { sessionId: "child-9" }, undefined, undefined, ctxFor("parent-1", undefined)))
|
|
.rejects.toThrow("not one of your subsessions");
|
|
});
|
|
});
|