From 8da7b29ba60f9b18a2bc879d35e665c9ec7428c5 Mon Sep 17 00:00:00 2001 From: Federico Jaramillo Martinez Date: Tue, 14 Jul 2026 23:56:24 +0200 Subject: [PATCH] fix(terminals): namespace terminal environment marker --- .changeset/add-pi-web-terminal-environment.md | 2 +- src/server/terminals/terminalService.test.ts | 22 +++++++++---------- src/server/terminals/terminalService.ts | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.changeset/add-pi-web-terminal-environment.md b/.changeset/add-pi-web-terminal-environment.md index 5fd24f2..16df1e5 100644 --- a/.changeset/add-pi-web-terminal-environment.md +++ b/.changeset/add-pi-web-terminal-environment.md @@ -2,4 +2,4 @@ "@jmfederico/pi-web": patch --- -Set `IS_PIWEB=1` in PI WEB terminal shells. +Set `PI_WEB_TERMINAL=1` in PI WEB terminal shells. diff --git a/src/server/terminals/terminalService.test.ts b/src/server/terminals/terminalService.test.ts index ca3aded..75f3957 100644 --- a/src/server/terminals/terminalService.test.ts +++ b/src/server/terminals/terminalService.test.ts @@ -22,23 +22,23 @@ describe.skipIf(process.platform === "win32")("TerminalService command runs", () } }); - describe("IS_PIWEB propagation", () => { - let originalIsPiWeb: string | undefined; + describe("PI_WEB_TERMINAL propagation", () => { + let originalPiWebTerminal: string | undefined; beforeEach(() => { - originalIsPiWeb = process.env["IS_PIWEB"]; - process.env["IS_PIWEB"] = "conflicting-parent-value"; + originalPiWebTerminal = process.env["PI_WEB_TERMINAL"]; + process.env["PI_WEB_TERMINAL"] = "conflicting-parent-value"; }); afterEach(() => { - if (originalIsPiWeb === undefined) { - delete process.env["IS_PIWEB"]; + if (originalPiWebTerminal === undefined) { + delete process.env["PI_WEB_TERMINAL"]; } else { - process.env["IS_PIWEB"] = originalIsPiWeb; + process.env["PI_WEB_TERMINAL"] = originalPiWebTerminal; } }); - it("sets IS_PIWEB for terminal commands", async () => { + it("sets PI_WEB_TERMINAL for terminal commands", async () => { const service = new TerminalService(); try { const frame = "__PI_WEB_RUN_ENV_7F3A9C__"; @@ -48,7 +48,7 @@ describe.skipIf(process.platform === "win32")("TerminalService command runs", () workspaceId: "w1", cwd: process.cwd(), title: "Environment check", - command: `printf '${frame}%s${frame}\\n' "$IS_PIWEB"`, + command: `printf '${frame}%s${frame}\\n' "$PI_WEB_TERMINAL"`, }); expect(await terminalExit(service, run.terminalId)).toContain(`${frame}1${frame}`); @@ -57,7 +57,7 @@ describe.skipIf(process.platform === "win32")("TerminalService command runs", () } }); - it("sets IS_PIWEB in a continued interactive shell", async () => { + it("sets PI_WEB_TERMINAL in a continued interactive shell", async () => { const service = new TerminalService(); try { const run = service.runCommand({ @@ -78,7 +78,7 @@ describe.skipIf(process.platform === "win32")("TerminalService command runs", () const frame = "__PI_WEB_CONTINUE_ENV_42D8B1__"; const exit = terminalExit(service, run.terminalId); - service.write(run.terminalId, `printf '${frame}%s${frame}\\n' "$IS_PIWEB"\nexit\n`); + service.write(run.terminalId, `printf '${frame}%s${frame}\\n' "$PI_WEB_TERMINAL"\nexit\n`); const output = await exit; expect(output).toContain("[continued in interactive shell]"); diff --git a/src/server/terminals/terminalService.ts b/src/server/terminals/terminalService.ts index db26e34..7186893 100644 --- a/src/server/terminals/terminalService.ts +++ b/src/server/terminals/terminalService.ts @@ -163,7 +163,7 @@ export class TerminalService { cwd: record.cwd, cols: 100, rows: 30, - env: { ...process.env, TERM: "xterm-256color", IS_PIWEB: "1" }, + env: { ...process.env, TERM: "xterm-256color", PI_WEB_TERMINAL: "1" }, }); this.attachPtyEvents(record); const info = toInfo(record); @@ -196,7 +196,7 @@ export class TerminalService { cwd: options.cwd, cols: options.cols ?? 100, rows: options.rows ?? 30, - env: { ...process.env, TERM: "xterm-256color", IS_PIWEB: "1" }, + env: { ...process.env, TERM: "xterm-256color", PI_WEB_TERMINAL: "1" }, }); const requestedName = options.name?.trim(); const record: TerminalRecord = {