test: close selected coverage gaps

src/server/sessions/authService.test.ts

@@ -1,6 +1,8 @@
 import { AuthStorage, ModelRegistry } from "@earendil-works/pi-coding-agent";
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
+import type { OAuthFlowState } from "../../shared/apiTypes.js";
 import { AuthService, type AuthChange } from "./authService.js";
+import { OAuthLoginFlowService } from "./oauthLoginFlowService.js";
 
 describe("AuthService", () => {
   it("saves API keys and emits a global auth change", () => {
@@ -30,6 +32,39 @@ describe("AuthService", () => {
     expect(changes).toEqual([]);
     auth.dispose();
   });
+
+  it("refreshes auth state after OAuth login completes", () => {
+    const authStorage = AuthStorage.inMemory();
+    const modelRegistry = ModelRegistry.create(authStorage);
+    const authFlows = new CapturingOAuthLoginFlowService();
+    const auth = new AuthService({ modelRegistry, authFlows });
+    const changes: AuthChange[] = [];
+    auth.subscribe((change) => { changes.push(change); });
+    const reload = vi.spyOn(authStorage, "reload");
+    const refresh = vi.spyOn(modelRegistry, "refresh");
+    const provider = authStorage.getOAuthProviders().find((option) => option.id === "anthropic");
+    if (provider === undefined) throw new Error("Expected built-in OAuth provider");
+
+    expect(auth.startOAuthLogin(provider.id)).toMatchObject({ providerId: provider.id, providerName: provider.name, status: "running" });
+
+    const startOptions = authFlows.startCalls.at(0);
+    if (startOptions === undefined) throw new Error("Expected OAuth flow to start");
+    expect(startOptions.providerId).toBe(provider.id);
+    expect(startOptions.providerName).toBe(provider.name);
+    expect(startOptions.authStorage).toBe(authStorage);
+    expect(changes).toEqual([]);
+
+    reload.mockClear();
+    refresh.mockClear();
+    if (startOptions.onComplete === undefined) throw new Error("Expected OAuth completion callback");
+    startOptions.onComplete();
+
+    expect(reload).toHaveBeenCalledOnce();
+    expect(refresh).toHaveBeenCalledOnce();
+    expect(changes).toEqual([{}]);
+    auth.dispose();
+    expect(authFlows.disposed).toBe(true);
+  });
 });
 
 function createAuthService(data: Parameters<typeof AuthStorage.inMemory>[0] = {}) {
@@ -40,3 +75,17 @@ function createAuthService(data: Parameters<typeof AuthStorage.inMemory>[0] = {}
   auth.subscribe((change) => { changes.push(change); });
   return { auth, authStorage, changes };
 }
+
+class CapturingOAuthLoginFlowService extends OAuthLoginFlowService {
+  readonly startCalls: Parameters<OAuthLoginFlowService["start"]>[0][] = [];
+  disposed = false;
+
+  override start(options: Parameters<OAuthLoginFlowService["start"]>[0]): OAuthFlowState {
+    this.startCalls.push(options);
+    return { flowId: "flow-1", providerId: options.providerId, providerName: options.providerName, status: "running", progress: [] };
+  }
+
+  override dispose(): void {
+    this.disposed = true;
+  }
+}