feat: consolidate iOS with API and web preserving history

ios/.artifacts/20260831-105824-plan-code-ui-audit/manifest.md

@@ -0,0 +1,183 @@
+# Task Manifest
+
+- Task: 20260831-105824-plan-code-ui-audit
+- Created: 2026-08-31T10:58:24Z
+- Orchestrator: build
+- Status: reviewing
+- Current owner: build
+- Last updated: 2026-08-31T21:58:00Z (iteration 09 implemented; awaiting re-review)
+
+## Objective
+
+Audit completion of PLAN.md, deeply review and debug the iOS codebase, evaluate the UI/UX against the Hope reference, specify a coherent redesign, and route all implementation changes through the coder agent.
+
+## Acceptance Criteria
+
+- Every PLAN.md phase and exit criterion is classified as verified, incomplete, blocked, superseded, or out of scope with evidence.
+- Deep review covers correctness, lifecycle/concurrency, networking/TLS, LiveKit protocol handling, media behavior, persistence, accessibility, UX, and missing tests.
+- UI/UX review inspects the current app and the square Hope element in /Users/shane/dev/hope-voice-api or related Hope projects.
+- Confirmed implementation defects are fixed only by the coder agent and independently reviewed.
+- Build and available tests or simulator checks are run and their exact outcomes recorded.
+- A concrete UI update specification is produced.
+
+## Artifact Index
+
+- brief.md: implementation and review contract
+- implementation.md: coder report (written 2026-08-31, model litellm-lan/qwen3.8-27b) — iterations 01–09 complete
+- review.md: independent code/debug review (verdict: changes-requested, 14 findings)
+- ui-ux-spec.md: UI/UX evaluation and redesign specification (written 2026-08-31 by coder research pass)
+- ui-research-implementation.md: coder UI research report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/01-request.md: build's confirmed-defect fix request
+- iterations/01-implementation.md: coder iteration 01 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/02-request.md: build's iteration 02 correction request (7 items)
+- iterations/02-implementation.md: coder iteration 02 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/02-review.md: reviewer retrospective of iteration 02 (model openai-codex/gpt-5.6-sol)
+- iterations/03-request.md: build's iteration 03 correction request (6 items)
+- iterations/03-implementation.md: coder iteration 03 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/04-request.md: build's consolidated iteration 04 contract (10 product + 2 doc items)
+- iterations/04-implementation.md: coder iteration 04 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/04-review.md: reviewer iteration 04 re-review (verdict: changes-requested, 7 findings)
+- iterations/05-request.md: build's iteration 05 correction request (8 items)
+- iterations/05-implementation.md: coder iteration 05 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/06-request.md: build's iteration 06 correction request (8 items)
+- iterations/06-implementation.md: coder iteration 06 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/06-review.md: reviewer iteration 06 re-review (verdict: changes-requested, 7 findings)
+- iterations/07-request.md: build's iteration 07 correction request (6 items)
+- iterations/07-implementation.md: coder iteration 07 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/07-review.md: reviewer iteration 07 re-review (verdict: changes-requested, 3 findings)
+- iterations/08-request.md: build's iteration 08 correction request (3 items)
+- iterations/08-implementation.md: coder iteration 08 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/08-review.md: reviewer iteration 08 re-review (verdict: changes-requested, 1 finding)
+- iterations/09-request.md: build's iteration 09 correction request (1 item)
+- iterations/09-implementation.md: coder iteration 09 report (written 2026-08-31, model litellm-lan/qwen3.8-27b)
+- iterations/09-review.md: reviewer iteration 09 final review (verdict: approve, 0 findings; model openai-codex/gpt-5.6-sol, actual model ID openai/gpt-5.6-sol)
+- iterations/: correction rounds
+- attachments/: supporting evidence
+
+## Iteration Log
+
+- 2026-08-31T10:58:24Z: Audit initialized after clearing prior todo list.
+- 2026-08-31 (UI research pass, coder): Located square Hope element = LED-wall avatar (hope-voice-api/web/style.css L331–392 + app.js L265–341; 320×320 px square, border-radius 26px, 21×21 dot grid). Audited all voice-ios SwiftUI sources. Wrote ui-ux-spec.md (full redesign spec: tokens, LED-wall formulas, bubbles/composer, motion, a11y, 4-phase plan) and ui-research-implementation.md. No product code changed.
+- 2026-08-31 (iteration 01 request, build): Wrote iterations/01-request.md with 10 confirmed defects to fix (MediaAPI decode, desired-state sync, reporting protocol, polling lifecycle, text-mode join/settings, failed retry, model preference, transcript dedupe, tests).
+- 2026-08-31 (iteration 01 implementation, coder, model litellm-lan/qwen3.8-27b): All 10 defects fixed. Files: MediaAPI.swift, MediaPlayerController.swift, VoiceSession.swift, SettingsStore.swift, ConversationView.swift, TranscriptHandler.swift, TranscriptHistory.swift, project.yml + regenerated Voice.xcodeproj, new Tests/ (3 files). Verification: xcodegen generate OK; XcodeBuildMCP test_sim → 7 passed / 0 failed / 0 skipped on iPhone 17 Pro simulator; no new Swift warnings. Reports: implementation.md + iterations/01-implementation.md. Status → reviewing, owner → reviewer.
+- 2026-08-31 (iteration 02 request, build): Wrote iterations/02-request.md with 7 corrections: text-mode binding fix, transcript dedupe replace-in-place, appliedDesired gate removal, deterministic MediaReconcileTests, independent join-mode sync, trackID capture in stop(), re-run tests.
+- 2026-08-31 (iteration 02 implementation, coder, model litellm-lan/qwen3.8-27b): All 7 corrections implemented. Files: SettingsStore.swift (removed callback), ConversationView.swift (.onChange + $settings.textMode binding), TranscriptHandler.swift (replace partial in place), MediaPlayerController.swift (removed appliedDesired gate, exposed reconcile, trackID param), VoiceSession.swift (independent sync ops), TranscriptDedupeTests.swift (regression + updated expectations), MediaReconcileTests.swift (deterministic tests + late-audio). Verification: XcodeBuildMCP test_sim → 12 passed / 0 failed / 0 skipped; build_sim → success. No compiler warnings. Reports: iterations/02-implementation.md + implementation.md updated.
+
+## Open Risks
+
+- PLAN.md claims full completion despite original real-device exit criteria remaining unverified.
+- No automated test files were found in the initial repository inventory.
+- Simulator microphone and webm playback limitations constrain end-to-end qualification.
+- The task tool selects configured fixed agent models; Build cannot override a subagent model per invocation.
+
+## Final Outcome
+
+Pending.
+
+## Reviewer Status Update (appended 2026-08-31T12:21:07Z)
+
+- Status: changes-requested
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol
+- Verdict: changes-requested
+- Report: `review.md`
+- Retrospective iteration-02 report: `iterations/02-review.md`
+- Current verification: XcodeBuildMCP test and build both failed compiling `Sources/Media/PinnedMediaResourceLoader.swift:94` (`Int?`/`Int64` mismatch); no current tests executed.
+- Review scope: complete current product diff, all sources/tests/resources, PLAN.md, UPDATE_PATH.md, artifacts through `iterations/03-request.md`, and relevant `hope-voice-api` web/agent/media reference code.
+
+## Iteration Log (continued)
+
+- 2026-08-31T12:21:07Z (independent reviewer, model openai-codex/gpt-5.6-sol): Deep review complete. Verdict changes-requested with 14 findings. Wrote `review.md` and retrospective `iterations/02-review.md`. The current tree contains partial unreported iteration-03 edits and does not compile; iteration-03 items 1 and 3 are unimplemented, item 2 partial, item 4 build-breaking/no test, items 5–6 implemented. Ownership returned to build for correction routing.
+- 2026-08-31T12:25:00Z (build): Wrote `iterations/03-request.md` (6 items) and consolidated `iterations/04-request.md` (10 product + 2 doc items, subsuming 03). Routed to coder.
+- 2026-08-31T12:50:00Z (coder, model litellm-lan/qwen3.8-27b): All iteration 03 and 04 items implemented. Fixed compile error (Int?/Int64), completed symmetric dedupe, mic interruption lifecycle, media interruption semantics, terminal failure cleanup, text-mode invariant, server config sanitization, visible history + truthful Clear, conversation-state alignment, stale-safe media publishing, resource loader hardening, TLS pin scoping, model picker copy, and documentation updates. Verification: XcodeBuildMCP test_sim → 16 passed / 0 failed / 0 skipped; build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/03-implementation.md + iterations/04-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+
+## Reviewer Status Update (appended 2026-08-31T13:02:29Z)
+
+- Status: changes-requested
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol
+- Verdict: changes-requested
+- Report: `iterations/04-review.md`
+- `review.md`: iteration-04 addendum appended; prior findings/evidence preserved.
+- Verification: current simulator build succeeded; test command reported 16 passed, but generated `Voice.xcodeproj` omits `PinnedMediaResourceLoaderTests.swift` and `ConversationStateTests.swift`, so 12 claimed tests did not run.
+- Findings: 7 total (5 high, 2 medium), covering test discovery/count, transcript duplication/repeat semantics, server-config application, recursive/incomplete failure teardown, no-resume media race, resource-loader lifecycle/thread safety, and mic interruption ordering.
+
+## Iteration Log (continued)
+
+- 2026-08-31T13:02:29Z (independent reviewer, model openai-codex/gpt-5.6-sol): Iteration 04 re-review completed. XcodeBuildMCP build succeeded and the currently discovered 16 tests passed, but two new test files were absent from the generated project. Verdict remains changes-requested. Wrote `iterations/04-review.md`, appended current evidence to `review.md`, and returned ownership to build.
+- 2026-08-31T13:05:00Z (build): Wrote `iterations/05-request.md` with 8 required corrections addressing all 7 findings from iteration 04 review. Routed to coder.
+- 2026-08-31T13:30:00Z (coder, model litellm-lan/qwen3.8-27b): All 8 iteration 05 items implemented. Regenerated project (all 5 test files present), fixed stream URL + EMA tests, rewrote transcript handler with single canonical collection + source-aware clock-testable dedupe, implemented real server URL Apply semantics, intentional idempotent room teardown with isTearingDown flag, no-resume media interruption safety with resumeSuppressed flag, resource-loader lifecycle completion (ObjectIdentifier keying, main-queue serialization, correct 206/200 content-length), and serialized mic interruption operations with sequence-based supersession. Verification: xcodegen generate OK; XcodeBuildMCP test_sim → 42 passed / 0 failed / 0 skipped across 5 suites (ConversationStateTests 5, MediaAPITests 3, TranscriptDedupeTests 17, PinnedMediaResourceLoaderTests 11, MediaReconcileTests 6); build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/05-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+- 2026-08-31T13:45:00Z (coder, model litellm-lan/qwen3.8-27b): All 8 iteration 06 items implemented. Removed clearAll() from startSession (history preserved), consume-on-suppress dedupe (second same-source repeat accepted), centralized teardownForFailure(message:) with .failed before disconnect, truthful .idle only after complete teardown in disconnect(), server Apply disabled while session not idle + isReplacingSession guard, await-based mic interruption serialization (flag set after mute completes, .ended awaits mute task), true map serialization via delegateQueue: .main on pinned URLSession, and 5 new focused tests. Verification: XcodeBuildMCP test_sim → 47 passed / 0 failed / 0 skipped across 5 suites (TranscriptDedupeTests 22, MediaReconcileTests 6, ConversationStateTests 5, MediaAPITests 3, PinnedMediaResourceLoaderTests 11); build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/06-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+
+## Reviewer Status Update (appended 2026-08-31T13:55:00Z)
+
+- Status: changes-requested
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol
+- Verdict: changes-requested
+- Report: `iterations/06-review.md`
+- `review.md`: iteration-06 addendum appended; prior findings/evidence preserved.
+- Verification: current XcodeBuildMCP simulator test passed 47/47 across all five discovered suites; separate simulator build succeeded; `git diff --check` clean.
+- Findings: 7 total (5 high, 1 medium, 1 low), covering failure/retry teardown overlap, incomplete mic-operation serialization, repeated-pair transcript loss, server replacement identity races, overlapping media-resume interruption races, failed-state server lockout/reactivity, and inaccurate suite breakdowns.
+
+## Iteration Log (continued)
+
+- 2026-08-31T13:55:00Z (independent reviewer, model openai-codex/gpt-5.6-sol): Iteration 06 re-review completed. All 47 discovered tests pass and the simulator build succeeds, but five high-severity source-order/lifecycle defects remain. Verdict changes-requested. Wrote `iterations/06-review.md`, appended `review.md`, and returned ownership to build for correction routing.
+- 2026-08-31T14:00:00Z (build): Wrote `iterations/07-request.md` with 6 required corrections addressing all 7 findings from iteration 06 review (failure teardown state, mic operation chain, consume-on-suppress dedupe, server replacement coalescing, media interruption retained task, suite counts). Routed to coder.
+- 2026-08-31T14:15:00Z (coder, model litellm-lan/qwen3.8-27b): All 6 iteration 07 items implemented. Added `.tearingDown` state (`.failed` published only after complete teardown, `connect()` rejects `.tearingDown`), single retained mic operation chain for both begin and end (each new op awaits predecessor, newer begin orders after in-flight old unmute), consume (remove) on cross-source suppress (P1,D1,P2,D2 and D1,P1,D2,P2 produce exactly two rows), server replacement coalescing with `pendingServerURL` + captured-config construction + `.failed` Apply permitted, retained media interruption task with sequence recheck before `player.play()`, and suite count/test title corrections. Verification: XcodeBuildMCP test_sim → 49 passed / 0 failed / 0 skipped across 5 suites (TranscriptDedupeTests 24, MediaReconcileTests 7, ConversationStateTests 5, MediaAPITests 1, PinnedMediaResourceLoaderTests 12); build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/07-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+
+## Reviewer Status Update (appended 2026-08-31T14:25:00Z)
+
+- Status: changes-requested
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol
+- Verdict: changes-requested
+- Report: `iterations/07-review.md`
+- `review.md`: iteration-07 addendum appended; prior findings/evidence preserved.
+- Verification: current XcodeBuildMCP simulator test passed 49/49 across all five discovered suites; separate simulator build succeeded; suite source counts match the report; `git diff --check` clean.
+- Findings: 3 total (2 high, 1 medium), covering a transient-state flaw in the retained mic chain, incomplete arbitrary server URL coalescing, and stale per-session fields after terminal failure cleanup.
+
+## Iteration Log (continued)
+
+- 2026-08-31T14:25:00Z (independent reviewer, model openai-codex/gpt-5.6-sol): Iteration 07 re-review completed. All 49 discovered tests pass and the simulator build succeeds, but two high and one medium code-correctness findings remain. Verdict changes-requested. Wrote `iterations/07-review.md`, appended `review.md`, and returned ownership to build for correction routing.
+- 2026-08-31T14:30:00Z (build): Wrote `iterations/08-request.md` with 3 required corrections addressing all 3 findings from iteration 07 review (transient mic-state flaw with explicit user intent, single retained worker loop for server replacement, clear ephemeral session fields before publishing failure). Routed to coder.
+- 2026-08-31T21:43:00Z (coder, model litellm-lan/qwen3.8-27b): All 3 iteration 08 items implemented. Added `userWantsMicMuted` field with interruption begin decision moved after predecessor await (begin A → end A/unmute → begin B now finishes muted), single retained worker loop for server replacement (every Apply writes `pendingServerURL`, one Task drains until empty; covers A→B→C), and terminal failure teardown clears all ephemeral fields (agent, isMuted, userWantsMicMuted, micError, models, selectedModel, isReconnecting, reconnectAttempted, micMutedByInterruption) with inbound control events restricted to active states. Verification: XcodeBuildMCP test_sim → 59 passed / 0 failed / 0 skipped across 6 suites (TranscriptDedupeTests 24, ConversationStateTests 10, MediaReconcileTests 7, ServerReplacementCoordinatorTests 5, PinnedMediaResourceLoaderTests 12, MediaAPITests 1); build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/08-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+
+## Reviewer Status Update (appended 2026-08-31T21:52:04Z)
+
+- Status: changes-requested
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol (actual model ID: openai/gpt-5.6-sol)
+- Verdict: changes-requested
+- Report: `iterations/08-review.md`
+- Aggregate report: `review.md` iteration-08 addendum appended; prior findings/evidence preserved.
+- Verification: current XcodeBuildMCP simulator test passed 59/59 across all six discovered suites; separate simulator build succeeded; suite source counts and generated-project membership match; `git diff --check` clean.
+- Findings: 1 medium. Mic user-intent/operation ordering and arbitrary A→B→C server replacement are accepted. Terminal failure reset remains callback-racy because direct old-room participant/connection callbacks can repopulate cleared ephemeral fields during teardown.
+
+## Iteration Log (continued)
+
+- 2026-08-31T21:52:04Z (independent reviewer, model openai-codex/gpt-5.6-sol; actual model ID openai/gpt-5.6-sol): Iteration 08 final review completed. All 59 discovered tests pass and the simulator build succeeds. One medium source-correctness finding remains in terminal-failure callback guarding, so verdict is changes-requested. Wrote `iterations/08-review.md`, appended `review.md`, and returned ownership to build. Device, server-format, and separate Hope UI implementation remain residual qualifications only.
+- 2026-08-31T21:55:00Z (build): Wrote `iterations/09-request.md` with 1 required correction addressing the callback-racy terminal reset finding from iteration 08 review (gate old-room callbacks on active states + teardown flag, final reset before .failed publication, focused deterministic coverage). Routed to coder.
+- 2026-08-31T21:58:00Z (coder, model litellm-lan/qwen3.8-27b): Iteration 09 correction implemented. Added `resetEphemeralFields()` shared helper and `shouldAcceptRoomCallback(state:isTearingDown:)` pure predicate to VoiceSession. Gated `participantDidConnect` on active lifecycle states + teardown flag. Added early return for `isTearingDown` in `didUpdateConnectionState` with per-branch active-state guards. Final `resetEphemeralFields()` call immediately before `.failed`/`.idle` publication erases any callback delivered during the `teardownRoom()` await. Six new deterministic tests verify the gating predicate for all state/teardown combinations. Verification: XcodeBuildMCP test_sim → 65 passed / 0 failed / 0 skipped across 6 suites (TranscriptDedupeTests 24, ConversationStateTests 16, MediaReconcileTests 7, ServerReplacementCoordinatorTests 5, PinnedMediaResourceLoaderTests 12, MediaAPITests 1); build_sim → success; no compiler warnings; git diff --check clean. Reports: iterations/09-implementation.md + implementation.md updated. Status → reviewing, owner → build (awaiting re-review).
+
+## Reviewer Status Update (appended 2026-08-31T22:06:00Z)
+
+- Status: reviewed — approved; final closure remains with build
+- Current owner: build
+- Reviewer: reviewer
+- Reviewer model: openai-codex/gpt-5.6-sol (actual model ID: openai/gpt-5.6-sol)
+- Verdict: approve
+- Report: `iterations/09-review.md`
+- Aggregate report: `review.md` iteration-09 final addendum appended; prior findings/evidence preserved.
+- Findings: 0 (`No findings`).
+- Verification: current XcodeBuildMCP simulator test passed 65/65 across all six discovered suites; separate simulator build succeeded; suite source counts and generated-project membership match; `git diff --check` clean.
+- Disposition: the iteration-08 callback race is closed and no simulator-testable/source-correctness work remains. Real-device behavior, supported server media format, and separate Hope UI implementation remain residual qualifications only.
+
+## Iteration Log (continued)
+
+- 2026-08-31T22:06:00Z (independent reviewer, model openai-codex/gpt-5.6-sol; actual model ID openai/gpt-5.6-sol): Iteration 09 final review approved with no findings. Exact participant/connection callback gates and final failure/disconnect resets are code-correct; all 65 tests pass, the simulator build succeeds, test discovery/counts match, and the diff check is clean. Wrote `iterations/09-review.md`, appended `review.md`, and returned ownership to build for final closure with device/server-format/Hope-UI qualifications retained.