fix: persist room operation cancellation across lost admission acknowledgments

control/chat_runs.py

@@ -108,6 +108,10 @@ class ChatRuns:
             accounts.db.execute('''CREATE TABLE IF NOT EXISTS chat_transport (
                 run_id TEXT PRIMARY KEY, owner TEXT NOT NULL REFERENCES users(id) ON DELETE CASCADE,
                 conversation_id TEXT NOT NULL, metadata TEXT NOT NULL)''')
+            accounts.db.execute('''CREATE TABLE IF NOT EXISTS chat_operation_cancellations (
+                owner TEXT NOT NULL REFERENCES users(id) ON DELETE CASCADE,
+                conversation_id TEXT NOT NULL, operation_key TEXT NOT NULL,
+                PRIMARY KEY(owner,conversation_id,operation_key))''')
 
     def capabilities(self):
         enabled = bool(getattr(self.adapter, 'available', True))
@@ -132,6 +136,28 @@ class ChatRuns:
             row = self.accounts.db.execute('SELECT metadata FROM chat_transport WHERE owner=? AND run_id=?', (owner, rid)).fetchone()
             return json.loads(row[0]) if row else None
 
+    def operation_cancelled(self, owner, cid, key):
+        with self.accounts.lock:
+            return self.accounts.db.execute('SELECT 1 FROM chat_operation_cancellations WHERE owner=? AND conversation_id=? AND operation_key=?', (owner, cid, key)).fetchone() is not None
+
+    async def cancel_operation(self, owner, cid, key):
+        if not isinstance(key, str) or not 1 <= len(key) <= 200 or '\x00' in key:
+            raise HTTPException(400, 'Invalid operation key')
+        async with self.admission_locks[owner]:
+            await self.call('get_conversation', owner, cid)
+            def remember():
+                with self.accounts.lock, self.accounts.db:
+                    existing = self.accounts.db.execute('SELECT 1 FROM chat_operation_cancellations WHERE owner=? AND conversation_id=? AND operation_key=?', (owner, cid, key)).fetchone()
+                    if not existing and self.accounts.db.execute('SELECT count(*) FROM chat_operation_cancellations WHERE owner=?', (owner,)).fetchone()[0] >= 10000:
+                        raise HTTPException(429, 'Operation cancellation limit reached')
+                    self.accounts.db.execute('INSERT OR IGNORE INTO chat_operation_cancellations VALUES(?,?,?)', (owner, cid, key))
+                    row = self.accounts.db.execute('SELECT run_id FROM chat_idempotency WHERE owner=? AND conversation_id=? AND key=?', (owner, cid, key)).fetchone()
+                    return row[0] if row else None
+            rid = await asyncio.to_thread(remember)
+            if rid:
+                return {'ok': True, 'run': await self.cancel(owner, rid)}
+            return {'ok': True, 'run': None}
+
     def authorized(self, owner, metadata):
         with self.accounts.lock:
             if metadata.get('room'):
@@ -176,6 +202,10 @@ class ChatRuns:
                         raise HTTPException(429, 'Chat queue full')
                 operation = await self.call('send', owner, cid, content, idempotency_key, attachment_ids, mode=mode)
                 rid = operation['run']['id']
+                if await asyncio.to_thread(self.operation_cancelled, owner, cid, idempotency_key):
+                    if operation['run']['status'] not in TERMINAL:
+                        operation['run'] = await self.cancel(owner, rid)
+                    return operation
                 metadata = await asyncio.to_thread(self.metadata, owner, rid)
                 if metadata is None:
                     settings = await asyncio.to_thread(self.accounts.get_model_settings, owner)